Fixes for issues #110 and #111#112
Conversation
|
|
||
| renderer.log(chalk.yellow('This will publish this plugin to', Constants.Registry)); | ||
|
|
||
| var c = semver.coerce(">=2.2"); |
There was a problem hiding this comment.
It isn't. Removed it - thanks!
| pattern: /.+/, | ||
| type: 'string', | ||
| default: properties.repository || 'not specified', | ||
| default: properties.repository ? properties.repository.type : undefined, |
There was a problem hiding this comment.
Minor but is it worth defaulting to 'git' as it will be the most common and mean the user can just hit return again?
There was a problem hiding this comment.
Actually, further to that, since git is required according to the regex below can this user entry be removed and added automatically?
There was a problem hiding this comment.
Yeah I wasn't clear on what was allowed for type/url. The spec isn't very explanatory: https://github.com/bower/spec/blob/master/json.md#repository. Shall we assume it must be of type git and a git:// protocol? Now that I think on, the underlying bower register command fails if you don't have a git:// protocol. So, propose we drop asking the user for a type and amend the regex to only allow git:// protocol; is that ok with you?
4 participants
@moloko mind having a quick look/test and let me know who else might be a good candidate for verification?